Parcourir la source

Refactoring in pointer down event handler, step 3 (#1888)

* Refactor: use pointer down state for alt duplication flag

* Refactor: use pointer down state for drag state

* Refactor: simplify over scrollbars check

* Refactor: move pointer move handler out of pointer down handler

* Refactor: move pointer up handler out of pointer down handler

* Refactor: further simplify scrollbar check state in pointer down event

* Refactor: pull out initial pointer down state creation
Michal Srb il y a 5 ans
Parent
commit
4ab4fce998
2 fichiers modifiés avec 537 ajouts et 636 suppressions
  1. 531 628
      src/components/App.tsx
  2. 6 8
      src/scene/scrollbars.ts

Fichier diff supprimé car celui-ci est trop grand
+ 531 - 628
src/components/App.tsx


+ 6 - 8
src/scene/scrollbars.ts

@@ -107,10 +107,11 @@ export const isOverScrollBars = (
   x: number,
   y: number,
 ): {
-  isOverHorizontalScrollBar: boolean;
-  isOverVerticalScrollBar: boolean;
+  isOverEither: boolean;
+  isOverHorizontal: boolean;
+  isOverVertical: boolean;
 } => {
-  const [isOverHorizontalScrollBar, isOverVerticalScrollBar] = [
+  const [isOverHorizontal, isOverVertical] = [
     scrollBars.horizontal,
     scrollBars.vertical,
   ].map((scrollBar) => {
@@ -122,9 +123,6 @@ export const isOverScrollBars = (
       y <= scrollBar.y + scrollBar.height
     );
   });
-
-  return {
-    isOverHorizontalScrollBar,
-    isOverVerticalScrollBar,
-  };
+  const isOverEither = isOverHorizontal || isOverVertical;
+  return { isOverEither, isOverHorizontal, isOverVertical };
 };

Certains fichiers n'ont pas été affichés car il y a eu trop de fichiers modifiés dans ce diff