소스 검색

fix: bind text to correct container when nested (#5307)

* fix: bind text to correct container when nested

* fix tests
Aakansha Doshi 3 년 전
부모
커밋
ec35d5db51
2개의 변경된 파일7개의 추가작업 그리고 3개의 파일을 삭제
  1. 4 3
      src/components/App.tsx
  2. 3 0
      src/element/textWysiwyg.test.tsx

+ 4 - 3
src/components/App.tsx

@@ -2224,12 +2224,13 @@ class App extends React.Component<AppProps, AppState> {
         existingTextElement = selectedElements[0];
       } else if (isTextBindableContainer(selectedElements[0], false)) {
         existingTextElement = getBoundTextElement(selectedElements[0]);
+      } else {
+        existingTextElement = this.getTextElementAtPosition(sceneX, sceneY);
       }
+    } else {
+      existingTextElement = this.getTextElementAtPosition(sceneX, sceneY);
     }
 
-    existingTextElement =
-      existingTextElement ?? this.getTextElementAtPosition(sceneX, sceneY);
-
     // bind to container when shouldBind is true or
     // clicked on center of container
     if (

+ 3 - 0
src/element/textWysiwyg.test.tsx

@@ -115,6 +115,9 @@ describe("textWysiwyg", () => {
         height: textSize,
         containerId: container.id,
       });
+      mutateElement(container, {
+        boundElements: [{ type: "text", id: text.id }],
+      });
 
       h.elements = [container, text];